Repository navigation
build: publish Electron output outside the project folder - #6
Merged
Merged
Conversation
Publish profiles now write to the user's Downloads\Nine\Publish folder so the output is not globbed into the next build and nested recursively, which produced over-long paths and MSB3030 copy errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xnodeoncode
approved these changes
Nov 12, 2026
xnodeoncode
left a comment
xnodeoncode
left a comment
Owner
There was a problem hiding this comment.
This commit changes the output directory or published files only.
There was a problem hiding this comment.
🟡 Changes recommended
The Linux publish profile relies on HOME, which is normally unset on Windows hosts, causing output to target the drive root and potentially fail with access denied instead of using the user's Downloads folder.
1 open issue
What changed in this PR
Moves publish destinations outside the project folder to prevent recursive inclusion of previous output, over-long paths, and MSB3030 copy errors.
Changes:
- Redirects Windows output to
$(USERPROFILE)\Downloads\Nine\Publish. - Redirects Linux output to
$(HOME)/Downloads/Nine/Publish. - Preserves configuration, framework, and runtime subfolders.
| File | Description |
|---|---|
4-Nine/Properties/PublishProfiles/win-x64.pubxml |
Changes the Windows publish destination to the user's Downloads folder. |
4-Nine/Properties/PublishProfiles/linux-x64.pubxml |
Changes the Linux publish destination to a HOME-based Downloads folder. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish profiles now write to the user's Downloads\Nine\Publish folder so the output is not globbed into the next build and nested recursively, which produced over-long paths and MSB3030 copy errors.